Skip to content

RHIDP-9114: change two variable convention to tuple for DB and Scale replica #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 7, 2025
Merged

RHIDP-9114: change two variable convention to tuple for DB and Scale replica #205

merged 3 commits into from
Oct 7, 2025

Conversation

skestwal
Copy link
Collaborator

@skestwal skestwal commented Oct 3, 2025

… replicas to single tuple convention

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 3, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@skestwal skestwal changed the title refactor(RHIDH-9114): change two variable convention for db and scale… refactor(RHIDH-9114): change two variable convention to tuple for DB and Scale replica Oct 3, 2025
@openshift-ci openshift-ci bot added the approved label Oct 3, 2025
@skestwal skestwal marked this pull request as ready for review October 3, 2025 10:15
@skestwal skestwal changed the title refactor(RHIDH-9114): change two variable convention to tuple for DB and Scale replica RHIDP-8793: change two variable convention to tuple for DB and Scale replica Oct 3, 2025
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Oct 3, 2025 •
edited by openshift-ci bot
Loading

@skestwal: This pull request references RHIDP-8793 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

… replicas to single tuple convention

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@skestwal skestwal changed the title RHIDP-8793: change two variable convention to tuple for DB and Scale replica RHIDP-9114: change two variable convention to tuple for DB and Scale replica Oct 3, 2025
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Oct 3, 2025 •
edited by openshift-ci bot
Loading

@skestwal: This pull request references RHIDP-9114 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

… replicas to single tuple convention

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

pmacik
pmacik reviewed Oct 3, 2025
View reviewed changes
pmacik
pmacik reviewed Oct 3, 2025
View reviewed changes
@skestwal skestwal requested a review from pmacik October 7, 2025 06:17
pmacik
pmacik requested changes Oct 7, 2025
View reviewed changes
@pmacik pmacik self-requested a review October 7, 2025 09:08
pmacik
pmacik approved these changes Oct 7, 2025
View reviewed changes
Copy link
Collaborator

@pmacik pmacik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Oct 7, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pmacik, skestwal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ceef768 into redhat-performance:main Oct 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pmacik pmacik pmacik approved these changes

@jhutar jhutar Awaiting requested review from jhutar

@yogananth-subramanian yogananth-subramanian Awaiting requested review from yogananth-subramanian

Assignees

@pmacik pmacik

Labels

approved jira/valid-reference lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@skestwal @openshift-ci-robot @pmacik